Fix code related to import statements with isort#1178
Open
stweil wants to merge 1 commit intoOCR-D:masterfrom
Open
Fix code related to import statements with isort#1178stweil wants to merge 1 commit intoOCR-D:masterfrom
stweil wants to merge 1 commit intoOCR-D:masterfrom
Conversation
The fix was done in a virtual Python environment:
pip install isort
isort .
It orders the import statements and fixes their formatting.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Contributor
Author
|
I think the Python code should follow the PEP 8 style guide. This pull request supports the intoduction of coding guidelines for the OCR-D code where using Using |
Contributor
Author
|
Tools which can help getting cleaner Python code: https://github.com/life4/awesome-python-code-formatters. |
Contributor
Author
|
OCR-D/format-converters#25 shows how PEP 8 style issues can be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix was done in a virtual Python environment:
It orders the import statements and fixes their formatting.